Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[coral]: Introduce GH action for Coral PR check #127

Merged
merged 1 commit into from
Oct 21, 2022
Merged

feat[coral]: Introduce GH action for Coral PR check #127

merged 1 commit into from
Oct 21, 2022

Conversation

SmuliS
Copy link
Contributor

@SmuliS SmuliS commented Oct 20, 2022

Run static checks (eslint + prettier) and unitests for every
PR that includes changes to /coral/**.

Resolves: #108, #109

st3fan
st3fan suggested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@st3fan st3fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Just a few small nits to harden this workflow.

.github/workflows/coral-pr-pipeline.yml Show resolved Hide resolved
.github/workflows/coral-pr-pipeline.yml Show resolved Hide resolved
.github/workflows/coral-pr-pipeline.yml Show resolved Hide resolved
st3fan
st3fan previously requested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@st3fan st3fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking to pin third party actions to be sure. We're ok with actions from github but want to be a little more strict with other sources.

.github/workflows/coral-pr-pipeline.yml Outdated Show resolved Hide resolved
.github/workflows/coral-pr-pipeline.yml Outdated Show resolved Hide resolved
@SmuliS
feat[coral]: Introduce GH action for Coral PR check
d7f942b 
Run static checks (eslint + prettier) and unitests for every
PR that includes changes to ´/coral/**´

Resolves: #108, #109
@SmuliS SmuliS force-pushed the smulis-add-gh-action-for-coral-pr-pipeline branch from 8323a24 to d7f942b Compare October 21, 2022 14:13
@SmuliS SmuliS dismissed st3fan’s stale review October 21, 2022 14:14

Comments addressed. We got exactly what we were looking from the security review.

jlprat
jlprat approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlprat jlprat merged commit f814b9e into coral Oct 21, 2022
@jlprat jlprat deleted the smulis-add-gh-action-for-coral-pr-pipeline branch October 21, 2022 14:48
@jlprat jlprat mentioned this pull request Oct 21, 2022
Merged
This was linked to issues Oct 24, 2022
🪸 ui-rewrite: Add github action for static checks #108
Closed
🪸 ui-rewrite: Add github action for unit testing #109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlprat jlprat jlprat approved these changes

@st3fan st3fan st3fan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪸 ui-rewrite: Add github action for unit testing 🪸 ui-rewrite: Add github action for static checks
3 participants
@SmuliS @st3fan @jlprat